Warn about client-side tags being dropped #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

IgnisRBX merged 5 commits into Roblox:main from Ketasaja:warn-about-client-tags-being-dropped

Jan 6, 2025

Contributor

Ketasaja commented Jan 3, 2025

Changes

This behavior can cause unexpected removal of tags added locally.

Checks

By submitting your pull request for review, you agree to the following:

This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
To the best of my knowledge, all proposed changes are accurate.


          Warn about client-side tags being dropped

f84f13e

Ketasaja requested a review from a team as a code owner

January 3, 2025 18:26

github-actions bot added the engine reference label

IgnisRBX reviewed

View reviewed changes

content/en-us/reference/engine/classes/CollectionService.yaml Outdated Show resolved Hide resolved

IgnisRBX reviewed

View reviewed changes

content/en-us/reference/engine/classes/CollectionService.yaml Outdated Show resolved Hide resolved


          Apply suggestions from code review

6e6a085

IgnisRBX reviewed

View reviewed changes

content/en-us/reference/engine/classes/CollectionService.yaml Outdated Show resolved Hide resolved

IgnisRBX reviewed

View reviewed changes

content/en-us/reference/engine/classes/Instance.yaml Outdated Show resolved Hide resolved

IgnisRBX reviewed

View reviewed changes

content/en-us/reference/engine/classes/Instance.yaml Outdated Show resolved Hide resolved


          Apply suggestions from code review

57c98f8

IgnisRBX reviewed

View reviewed changes

content/en-us/reference/engine/classes/CollectionService.yaml Outdated Show resolved Hide resolved

IgnisRBX reviewed

View reviewed changes

content/en-us/reference/engine/classes/Instance.yaml Outdated Show resolved Hide resolved


          Apply suggestions from code review

62e5b96

IgnisRBX approved these changes

View reviewed changes


          Merge branch 'main' into warn-about-client-tags-being-dropped

eb87a70

IgnisRBX merged commit eaddbfe into Roblox:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine reference